-
Notifications
You must be signed in to change notification settings - Fork 6k
getRemoteUser() returns principal name #9211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closing this PR. I can't run the integration tests on my computer. They always fail. Feel free to use the code if you wish. It takes too much time to try to submit PRs to this project and I can't justify spending any more time trying to make this work. |
@sjrd218, I'm sorry things didn't work well for you. If you are still interested, I wonder if the slow-down you are experiencing is something that I can help with. Would you be able to post details about the issues that you were having? For example, what were the integration test failures, and what was it that was taking too much time? There might be solutions to both, and it would be helpful for others who experience the same issues that you did. |
This is a showstopper for my team.. Any way to release this bugfix sooner than 5.5.0.M2? |
Hi, @lnxmad. There are no releases planned before Can your problem be addressed by using a custom principal whose If neither of those work, then sharing more detail about your issue might help. |
I did consider a filter to wrap request, however Thanks for the quick response! |
You might consider injecting a custom @Bean
OAuth2UserService<OidcUserRequest, OidcUser> oidcUserService() {
OidcUserService delegate = new OidcUserService(); // the default
return (userRequest) -> {
OidcUser oidcUser = delegate.loadUser(userRequest);
return new MyCustomOidcUser(oidcUser);
}
} |
Returns the name of the authenticated principle instead of falling through to the toString() method which may render a string representation of the entire object rather than a username.
This behavior is helpful in OAuth2 and Saml2 configurations.
Closes #3357